Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak in HcalDbService #15686

Merged
merged 1 commit into from
Sep 1, 2016
Merged

fix memory leak in HcalDbService #15686

merged 1 commit into from
Sep 1, 2016

Conversation

kpedro88
Copy link
Contributor

Some dynamically allocated members of HcalDbService were never deleted, causing a memory leak. This PR fixes the problem (checked with igprof mp).

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Aug 31, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CalibFormats/HcalObjects

@ghellwig, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2016 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/14869/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 717c97e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15686/14869/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15686/14869/summary.html

@mmusich
Copy link
Contributor

mmusich commented Sep 1, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1084b90 into cms-sw:CMSSW_8_1_X Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@kpedro88 @cmsbuild @mmusich @davidlange6